pinctrl: nexell: Cannot test unsigned to be negative
In s5pxx18_pinctrl_set_state testing count to be negative will always fail as count is unsigned despite receiving the return value of a function that returns an int. Change count and idx to be of type int to allow the test to work as expected and remove the need for any implicit casts. Also change pin to be u32 which is what all called functions expect. This issue was found by Smatch. Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
This commit is contained in:
committed by
Tom Rini
parent
fedbb7a338
commit
e416d16572
@@ -130,7 +130,8 @@ static int is_pin_alive(const char *name)
|
||||
static int s5pxx18_pinctrl_set_state(struct udevice *dev,
|
||||
struct udevice *config)
|
||||
{
|
||||
unsigned int count, idx, pin;
|
||||
u32 pin;
|
||||
int count, idx;
|
||||
unsigned int pinfunc, pinpud, pindrv;
|
||||
unsigned long reg;
|
||||
const char *name;
|
||||
|
||||
Reference in New Issue
Block a user