cmd: x86: zboot: remove duplicate zboot_setup() call in do_zboot_setup

do_zboot_setup() invokes zboot_setup() twice: once with proper error
reporting, and again immediately afterwards with no diagnostic. The
second call re-runs the entire boot parameter setup on the
already-populated zero page, which is at best wasted work and at
worst leaves the structure in an unexpected state.

Drop the stray second invocation; the first call already covers both
success and failure handling.

Fixes: cb19931ee5 ("x86: zboot: Drop intermediate zboot_setup() function")
Signed-off-by: Naveen Kumar Chaudhary <naveen.osdev@gmail.com>

This commit is contained in:

Naveen Kumar Chaudhary

2026-07-10 15:52:59 -06:00

committed by

Tom Rini

parent bd93d8ea10

commit e0d10a4b85

1 changed files with 0 additions and 3 deletions

									
										cmd/x86/zboot.c
									
		-3
	
												View File
												
				@@ -66,9 +66,6 @@ static int do_zboot_setup(struct cmd_tbl *cmdtp, int flag, int argc,

						return CMD_RET_FAILURE;

					}

					if (zboot_setup())

						return CMD_RET_FAILURE;

					return 0;

				}