vhaudiquet/u-boot-krane
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cmd: i3c: fix list and current needing pre-selected controller

Browse Source 
The !currdev guard in do_i3c() was placed before the list and current
handlers, causing both to fail when no controller is pre-selected.
Move the guard to only protect device_list, write and read which
actually need a controller.

Fixes: b875409da7 ("cmd: Add i3c command support.")
Signed-off-by: Pranav Tilak <pranav.vinaytilak@amd.com>
Reviewed-by: Dinesh Maniyam <dinesh.maniyam@altera.com>
This commit is contained in:
Pranav Tilak
2026-07-22 13:10:17 -06:00
committed by Tom Rini
parent f077a6b07b
commit b2062131b4
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cmd/i3c.c
+6 -5
View File
@@ -240,16 +240,17 @@ static int do_i3c(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
if (!is_i3c_subcommand(subcmd))
return handle_i3c_select(subcmd);
if (!strcmp(subcmd, "list"))
return handle_i3c_list();
else if (!strcmp(subcmd, "current"))
return handle_i3c_current();
if (!currdev) {
printf("i3c: No I3C controller selected\n");
return CMD_RET_FAILURE;
}
if (!strcmp(subcmd, "list"))
return handle_i3c_list();
else if (!strcmp(subcmd, "current"))
return handle_i3c_current();
else if (!strcmp(subcmd, "device_list"))
if (!strcmp(subcmd, "device_list"))
return handle_i3c_device_list();
else if (!strcmp(subcmd, "write"))
return handle_i3c_write(argc, argv);