phy: marvell: Fix off by 1 limit checks
The limit checks in get_speed_string and get_type_string are off by 1 as they do not account for the maximum index into an array that can be used is 1 less than the number of elements in that array. Adjust the limit checks to allow for this. This issue was found by Smatch. Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org> Reviewed-by: Stefan Roese <stefan.roese@mailbox.org>
This commit is contained in:
committed by
Jerome Forissier
parent
4b2d64f388
commit
a75c8a4b88
@@ -28,7 +28,7 @@ static const char *get_speed_string(u32 speed)
|
||||
"10.3125 Gbps"
|
||||
};
|
||||
|
||||
if (speed < 0 || speed > COMPHY_SPEED_MAX)
|
||||
if (speed < 0 || speed >= COMPHY_SPEED_MAX)
|
||||
return "invalid";
|
||||
|
||||
return speed_strings[speed];
|
||||
@@ -44,7 +44,7 @@ static const char *get_type_string(u32 type)
|
||||
"IGNORE"
|
||||
};
|
||||
|
||||
if (type < 0 || type > COMPHY_TYPE_MAX)
|
||||
if (type < 0 || type >= COMPHY_TYPE_MAX)
|
||||
return "invalid";
|
||||
|
||||
return type_strings[type];
|
||||
|
||||
Reference in New Issue
Block a user