vhaudiquet/u-boot-krane
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cmd: host: fix duplicate device_unbind and wrong error message in unbind

Browse Source 
do_host_unbind()'s error handler for device_unbind() prints the
misleading message "Cannot attach file" and then calls device_unbind()
a second time on the same device, both of which look like copy-paste
mistakes left over from neighbouring code.

Remove the duplicate device_unbind() call and report the correct
failure with the device name.

Fixes: 952018117a ("dm: sandbox: Switch over to using the new host uclass")
Signed-off-by: Naveen Kumar Chaudhary <naveen.osdev@gmail.com>
This commit is contained in:
Naveen Kumar Chaudhary
2026-07-10 15:51:21 -06:00
committed by Tom Rini
parent dc3606a961
commit 9df08fb181
1 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cmd/host.c
+1 -4
View File
@@ -132,10 +132,7 @@ static int do_host_unbind(struct cmd_tbl *cmdtp, int flag, int argc,
ret = device_unbind(dev);
if (ret) {
printf("Cannot attach file\n");
ret = device_unbind(dev);
if (ret)
printf("Cannot unbind device '%s'\n", dev->name);
printf("Cannot unbind device '%s'\n", dev->name);
return CMD_RET_FAILURE;
}