arm64: a37xx: pinctrl: fix info->dev used but never set

A bunch of code calls info->dev, mostly dev_* messages and devm_kzalloc.

The former can be passed a NULL device and _dev_printk handles this just
fine.
The latter ignores the dev argument whenever !CONFIG_IS_ENABLED(DEVRES)
which was true in most cases until we made CONFIG_DEVRES mandatory for
U-Boot proper in commit 217cf656e2 ("dm: core: Default to using DEVRES
outside of xPL"). Failing to set info->dev before it's used by
devm_kzalloc results in crashes, therefore let's set info->dev before it
can be used.

Reported-by: Ben Schneider <ben@bens.haus>
Closes: https://lore.kernel.org/u-boot/IRefanijM8fTzOXeGe-H5hmhRkm7pt4Q83BV6VcWKlWp0s4i8mYcONTQz-IVhvNWlGta4LtnfK7ti6gxlrqq8h8cotgG1S0Fs6_DviAHvyo=@bens.haus/
Fixes: 0871806629 ("pinctrl: armada-37xx: Add pin controller support for Armada 37xx")
Fixes: 217cf656e2 ("dm: core: Default to using DEVRES outside of xPL")
Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
Tested-by: Ben Schneider <ben@bens.haus>
Reviewed-by: Stefan Roese <stefan.roese@mailbox.org>

This commit is contained in:

Quentin Schulz

2026-07-30 21:04:16 +02:00

committed by

Stefan Roese

parent 100e12ea78

commit 93c1d38cd8

1 changed files with 2 additions and 0 deletions

									
										drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
									
		+2
		
												View File
												
				@@ -720,6 +720,8 @@ static int armada_37xx_pinctrl_probe(struct udevice *dev)

						return -ENODEV;

					}

					info->dev = dev;

					/*

					 * we allocate functions for number of pins and hope there are

					 * fewer unique functions than pins available