vhaudiquet/u-boot-krane
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

common/command.c: Avoid NULL pointer use in cmd_auto_complete

Browse Source 
Avoid using ps_prompt having a NULL pointer. For that, use the same
approach as in uboot_cli_readline().

Suggested-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Adam Lackorzynski <adam@l4re.org>
Reviewed-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
Adam Lackorzynski
2026-05-27 17:59:16 -06:00
committed by Tom Rini
parent 7af4196d9e
commit 8429766a7f
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
common/command.c
+9 -5
View File
@@ -367,11 +367,15 @@ int cmd_auto_complete(const char *const prompt, char *buf, int *np, int *colp)
int i, j, k, len, seplen, argc;
int cnt;
char last_char;
#ifdef CONFIG_CMDLINE_PS_SUPPORT
const char *ps_prompt = env_get("PS1");
#else
const char *ps_prompt = CONFIG_SYS_PROMPT;
#endif
const char *ps_prompt;
if (IS_ENABLED(CONFIG_CMDLINE_PS_SUPPORT)) {
ps_prompt = env_get("PS1");
if (!ps_prompt)
ps_prompt = CONFIG_SYS_PROMPT;
} else
ps_prompt = CONFIG_SYS_PROMPT;
if (strcmp(prompt, ps_prompt) != 0)
return 0; /* not in normal console */