power: regulator: Fix incorrect use of binary and
In regulator_list_autoset there is a test for ret being non-zero and error being zero but it uses the binary '&' instead of the logical '&&' which could well lead to unexpected results. Correct this to use the logical '&&' instead. This issue found by Smatch. Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org> Reviewed-by: Peng Fan <peng.fan@nxp.com> Signed-off-by: Peng Fan <peng.fan@nxp.com>
This commit is contained in:
committed by
Peng Fan
parent
e482fdbbca
commit
6c98e6014b
@@ -389,7 +389,7 @@ int regulator_list_autoset(const char *list_platname[],
|
||||
ret = regulator_autoset_by_name(list_platname[i], &dev);
|
||||
if (ret != -EMEDIUMTYPE && verbose)
|
||||
regulator_show(dev, ret);
|
||||
if (ret & !error)
|
||||
if (ret && ret != -EALREADY && !error)
|
||||
error = ret;
|
||||
|
||||
if (list_devp)
|
||||
|
||||
Reference in New Issue
Block a user