vhaudiquet/u-boot-krane
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

clk: renesas: Do not test unsigned variable to be less than 0

Browse Source 
In rcar_clk_set_rate64_div_table the unsigned variable 'value' is used
to receive the return value from rcar_clk_get_table_val which returns an
int and then attempts to test for being less than 0, which can never be
true. Instead declare value as an int so the code can behave as
expected. Also remove initial values from 'value' and 'div' as they are
not needed.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
Reviewed-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
This commit is contained in:
Andrew Goodbody
2025-08-06 16:52:27 +02:00
committed by Marek Vasut
parent 007610da2c
commit 4ef864f1ae
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/clk/renesas/rcar-cpg-lib.c
+3 -2
View File
@@ -92,7 +92,8 @@ int rcar_clk_set_rate64_div_table(unsigned int parent, u64 parent_rate, ulong ra
void __iomem *reg, const u32 mask,
const struct clk_div_table *table, char *name)
{
u32 value = 0, div = 0;
u32 div;
int value;
div = DIV_ROUND_CLOSEST(parent_rate, rate);
value = rcar_clk_get_table_val(table, div);
@@ -101,7 +102,7 @@ int rcar_clk_set_rate64_div_table(unsigned int parent, u64 parent_rate, ulong ra
clrsetbits_le32(reg, mask, field_prep(mask, value));
debug("%s[%i] %s clk: parent=%i div=%u rate=%lu => val=%u\n",
debug("%s[%i] %s clk: parent=%i div=%u rate=%lu => val=%d\n",
__func__, __LINE__, name, parent, div, rate, value);
return 0;