reset: ast: Use dev_read_addr_ptr()
Use dev_read_addr_ptr() which supports both live device tree and flat DT backends, avoiding direct dependency on devfdt_* helpers. While at here, correct error return value, when priv->scu is NULL, PTR_ERR(priv->scu) is 0 which implies success. Change to return '-EINVAL'. No functional changes. Signed-off-by: Peng Fan <peng.fan@nxp.com>
This commit is contained in:
@@ -77,10 +77,10 @@ static int ast2500_reset_probe(struct udevice *dev)
|
||||
return rc;
|
||||
}
|
||||
|
||||
priv->scu = devfdt_get_addr_ptr(scu_dev);
|
||||
priv->scu = dev_read_addr_ptr(scu_dev);
|
||||
if (IS_ERR_OR_NULL(priv->scu)) {
|
||||
debug("%s: invalid SCU base pointer\n", __func__);
|
||||
return PTR_ERR(priv->scu);
|
||||
return -EINVAL;
|
||||
}
|
||||
|
||||
return 0;
|
||||
|
||||
@@ -76,10 +76,10 @@ static int ast2600_reset_probe(struct udevice *dev)
|
||||
return rc;
|
||||
}
|
||||
|
||||
priv->scu = devfdt_get_addr_ptr(scu_dev);
|
||||
priv->scu = dev_read_addr_ptr(scu_dev);
|
||||
if (IS_ERR_OR_NULL(priv->scu)) {
|
||||
debug("%s: invalid SCU base pointer\n", __func__);
|
||||
return PTR_ERR(priv->scu);
|
||||
return -EINVAL;
|
||||
}
|
||||
|
||||
return 0;
|
||||
|
||||
Reference in New Issue
Block a user