context: quote program, args, cwd and env in ssh, schroot and unshare drivers

All three non-local drivers assembled remote/chroot command strings by
raw concatenation: ssh pushed args verbatim (TODO: escape), schroot
interpolated env values raw so DEB_BUILD_OPTIONS='parallel=4 nocheck'
made sh treat 'nocheck' as the command, and unshare wrapped args in
unescaped double quotes letting quotes break out and $/backticks
expand. Add a shared POSIX shell_quote helper and use it for every
component interpolated into a shell string, including ssh copy_path
(which used Rust's {:?}, not shell quoting) and schroot write_file
(which also switches echo -ne to printf %s so backslash sequences in
content are no longer interpreted).

This commit is contained in:

vhaudiquet

2026-09-16 00:36:02 +02:00

parent 685538e637

commit f508f20846

5 changed files with 386 additions and 71 deletions

									
										src/context/mod.rs
									
		+1
		
												View File
												
				@@ -3,6 +3,7 @@ pub(crate) mod capture;

				mod local;

				mod manager;

				mod schroot;

				pub(crate) mod shell;

				mod ssh;

				mod unshare;