docs: reflect the single upload-warnings question
The section also sorted the backport-suffix check under the outright stops; it is a warning, like no-bug, placeholders and the maintainer check.
This commit is contained in:
1 parent
8bfc9d5677
commit
66053d3ad5
1 file changed
+13
-9
@@ -257,28 +257,32 @@ tests, no usable testbed, ...).
|
|||||||
### Pre-upload checks
|
### Pre-upload checks
|
||||||
|
|
||||||
`pkh put` inspects the `.changes` file (and the source tree next to it)
|
`pkh put` inspects the `.changes` file (and the source tree next to it)
|
||||||
before anything is uploaded, refusing or questioning common upload
|
before anything is uploaded, refusing or warning about common upload
|
||||||
mistakes the archive queue would accept silently. The guards are adapted
|
mistakes the archive queue would accept silently. The guards are adapted
|
||||||
from Christian Ehrhardt's dput hooks, and stop uploads carrying:
|
from Christian Ehrhardt's dput hooks. Every reason found is shown before
|
||||||
|
anything stops, so one rebuild can fix everything at once.
|
||||||
|
|
||||||
|
Two mistakes stop the upload outright:
|
||||||
|
|
||||||
- an `ubuntu@` or `root@` address in `Changed-By` (a container or VM
|
- an `ubuntu@` or `root@` address in `Changed-By` (a container or VM
|
||||||
default identity leaked into the changelog),
|
default identity leaked into the changelog),
|
||||||
- a `~YY.MM` backport suffix not matching the target series
|
|
||||||
(`1.0-0ubuntu1~20.10` uploading to focal, which is 20.04),
|
|
||||||
- quilt patches (`debian/patches/series`) in a native package, where
|
- quilt patches (`debian/patches/series`) in a native package, where
|
||||||
they would never apply.
|
they would never apply.
|
||||||
|
|
||||||
Others ask for confirmation, defaulting to "no" so non-interactive runs
|
The others warn, and pkh then asks a single "Upload with warnings?"
|
||||||
refuse the same way:
|
question (defaulting to "no", so non-interactive runs refuse the same
|
||||||
|
way):
|
||||||
|
|
||||||
- no Launchpad bug reference in the changelog entry, or one of the usual
|
- no Launchpad bug reference in the changelog entry, or one of the usual
|
||||||
placeholder numbers (`1234`, `9999`),
|
placeholder numbers (`1234`, `9999`),
|
||||||
|
- a `~YY.MM` backport suffix not matching the target series
|
||||||
|
(`1.0-0ubuntu1~20.10` uploading to focal, which is 20.04),
|
||||||
- Ubuntu changes (`1.0-1ubuntu1`) without an ubuntu.com `Maintainer`
|
- Ubuntu changes (`1.0-1ubuntu1`) without an ubuntu.com `Maintainer`
|
||||||
(`update-maintainer` was not run).
|
(`update-maintainer` was not run).
|
||||||
|
|
||||||
Every refusal names the mistake and the way out: `--force` uploads
|
The way out is always the same: `--force` uploads anyway, skipping the
|
||||||
anyway, skipping the mistake checks together with the duplicate-upload
|
mistake checks together with the duplicate-upload and
|
||||||
and superseded-version guards. `pkh build` collects `LP: #NNN` changelog
|
superseded-version guards. `pkh build` collects `LP: #NNN` changelog
|
||||||
references into the `Launchpad-Bugs-Fixed` field of the `.changes` file
|
references into the `Launchpad-Bugs-Fixed` field of the `.changes` file
|
||||||
like Ubuntu's `dpkg-genchanges` does, which is what the bug-reference
|
like Ubuntu's `dpkg-genchanges` does, which is what the bug-reference
|
||||||
guards read.
|
guards read.
|
||||||
|
|||||||
Reference in new issue
Block a user