From 66053d3ad56d9f811c08bd07cc321f542ea6f789 Mon Sep 17 00:00:00 2001 From: Valentin Haudiquet Date: Tue, 17 Nov 2026 12:50:49 +0100 Subject: [PATCH] docs: reflect the single upload-warnings question The section also sorted the backport-suffix check under the outright stops; it is a warning, like no-bug, placeholders and the maintainer check. --- README.md | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/README.md b/README.md index dba614f..11acb7e 100644 --- a/README.md +++ b/README.md @@ -257,28 +257,32 @@ tests, no usable testbed, ...). ### Pre-upload checks `pkh put` inspects the `.changes` file (and the source tree next to it) -before anything is uploaded, refusing or questioning common upload +before anything is uploaded, refusing or warning about common upload mistakes the archive queue would accept silently. The guards are adapted -from Christian Ehrhardt's dput hooks, and stop uploads carrying: +from Christian Ehrhardt's dput hooks. Every reason found is shown before +anything stops, so one rebuild can fix everything at once. + +Two mistakes stop the upload outright: - an `ubuntu@` or `root@` address in `Changed-By` (a container or VM default identity leaked into the changelog), -- a `~YY.MM` backport suffix not matching the target series - (`1.0-0ubuntu1~20.10` uploading to focal, which is 20.04), - quilt patches (`debian/patches/series`) in a native package, where they would never apply. -Others ask for confirmation, defaulting to "no" so non-interactive runs -refuse the same way: +The others warn, and pkh then asks a single "Upload with warnings?" +question (defaulting to "no", so non-interactive runs refuse the same +way): - no Launchpad bug reference in the changelog entry, or one of the usual placeholder numbers (`1234`, `9999`), +- a `~YY.MM` backport suffix not matching the target series + (`1.0-0ubuntu1~20.10` uploading to focal, which is 20.04), - Ubuntu changes (`1.0-1ubuntu1`) without an ubuntu.com `Maintainer` (`update-maintainer` was not run). -Every refusal names the mistake and the way out: `--force` uploads -anyway, skipping the mistake checks together with the duplicate-upload -and superseded-version guards. `pkh build` collects `LP: #NNN` changelog +The way out is always the same: `--force` uploads anyway, skipping the +mistake checks together with the duplicate-upload and +superseded-version guards. `pkh build` collects `LP: #NNN` changelog references into the `Launchpad-Bugs-Fixed` field of the `.changes` file like Ubuntu's `dpkg-genchanges` does, which is what the bug-reference guards read.