vhaudiquet/u-boot-krane
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
4e3f64c7cc0c6a5defdceb485313b8a33f231f10
u-boot-krane/test/dm/reset.c
T
Michal Simek 4e3f64c7cc reset: sandbox: Cover reset_reset() fallback with second sandbox provider 
Add a sandbox reset controller compatible string
"sandbox,reset-ctl-fallback-only" that reuses the existing sandbox assert,
deassert, request, and free helpers but omits rst_reset. That forces
reset_reset() through the core assert / udelay / deassert fallback.

Extend the reset-ctl-test DT node with a fifth reset line named "fallback"
that points at the new provider, and add dm_test_reset_reset_fallback_path
which verifies sandbox_reset_get_count() stays zero (rst_reset is never
invoked) while the line ends deasserted after reset_reset().

This complements the existing rst_reset coverage on sandbox,reset-ctl and
matches the approach of using a separate controller to exercise the
fallback path in unit tests.

Reviewed-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Michal Simek <michal.simek@amd.com>
Link: https://lore.kernel.org/r/c1d40db6e2332a8b23ba842385b3f8c3d0290109.1779709539.git.michal.simek@amd.com
2026-06-08 10:50:06 +02:00

291 lines
10 KiB
C
Raw Blame History

// SPDX-License-Identifier: GPL-2.0
/*
* Copyright (c) 2016, NVIDIA CORPORATION.
*/
#include <dm.h>
#include <dm/device-internal.h>
#include <log.h>
#include <malloc.h>
#include <reset.h>
#include <dm/test.h>
#include <asm/reset.h>
#include <test/test.h>
#include <test/ut.h>
/* This must match the specifier for mbox-names="test" in the DT node */
#define TEST_RESET_ID 2
/* This is the other reset phandle specifier handled by bulk */
#define OTHER_RESET_ID 2
/* Line on reset-ctl-fallback (sandbox,reset-ctl-fallback-only); see test.dts */
#define FALLBACK_RESET_ID 5
/* Base test of the reset uclass */
static int dm_test_reset_base(struct unit_test_state *uts)
{
struct udevice *dev;
struct reset_ctl reset_method1, reset_method1_1;
struct reset_ctl reset_method2, reset_method2_1;
struct reset_ctl reset_method3, reset_method3_1;
struct reset_ctl reset_method4, reset_method4_1;
/* Get the device using the reset device */
ut_assertok(uclass_get_device_by_name(UCLASS_MISC, "reset-ctl-test",
&dev));
/* Get the same reset port in 2 different ways and compare */
ut_assertok(reset_get_by_index(dev, 0, &reset_method1));
ut_assertok(reset_get_by_name(dev, NULL, &reset_method1_1));
ut_assertok(reset_get_by_index(dev, 1, &reset_method2));
ut_assertok(reset_get_by_index_nodev(dev_ofnode(dev), 1,
&reset_method2_1));
ut_assertok(reset_get_by_index(dev, 2, &reset_method3));
ut_assertok(reset_get_by_index_nodev(dev_ofnode(dev), 2,
&reset_method3_1));
ut_assertok(reset_get_by_index(dev, 3, &reset_method4));
ut_assertok(reset_get_by_index_nodev(dev_ofnode(dev), 3,
&reset_method4_1));
ut_asserteq(reset_method1.id, reset_method1_1.id);
ut_asserteq(reset_method2.id, reset_method2_1.id);
ut_asserteq(reset_method3.id, reset_method3_1.id);
ut_asserteq(reset_method4.id, reset_method4_1.id);
ut_asserteq(true, reset_method1.id != reset_method2.id);
ut_asserteq(true, reset_method1.id != reset_method3.id);
ut_asserteq(true, reset_method1.id != reset_method4.id);
ut_asserteq(true, reset_method2.id != reset_method3.id);
ut_asserteq(true, reset_method2.id != reset_method4.id);
ut_asserteq(true, reset_method3.id != reset_method4.id);
ut_asserteq(true, reset_method1_1.id != reset_method2_1.id);
ut_asserteq(true, reset_method1_1.id != reset_method3_1.id);
ut_asserteq(true, reset_method1_1.id != reset_method4_1.id);
ut_asserteq(true, reset_method2_1.id != reset_method3_1.id);
ut_asserteq(true, reset_method2_1.id != reset_method4_1.id);
ut_asserteq(true, reset_method3_1.id != reset_method4_1.id);
return 0;
}
DM_TEST(dm_test_reset_base, UTF_SCAN_FDT);
static int dm_test_reset(struct unit_test_state *uts)
{
struct udevice *dev_reset;
struct udevice *dev_test;
ut_assertok(uclass_get_device_by_name(UCLASS_RESET, "reset-ctl",
&dev_reset));
ut_asserteq(0, sandbox_reset_query(dev_reset, TEST_RESET_ID));
ut_assertok(uclass_get_device_by_name(UCLASS_MISC, "reset-ctl-test",
&dev_test));
ut_assertok(sandbox_reset_test_get(dev_test));
ut_assertok(sandbox_reset_test_assert(dev_test));
ut_asserteq(1, sandbox_reset_query(dev_reset, TEST_RESET_ID));
ut_assertok(sandbox_reset_test_deassert(dev_test));
ut_asserteq(0, sandbox_reset_query(dev_reset, TEST_RESET_ID));
ut_asserteq(1, sandbox_reset_is_requested(dev_reset, TEST_RESET_ID));
ut_assertok(sandbox_reset_test_free(dev_test));
ut_asserteq(0, sandbox_reset_is_requested(dev_reset, TEST_RESET_ID));
return 0;
}
DM_TEST(dm_test_reset, UTF_SCAN_FDT);
static int dm_test_reset_devm(struct unit_test_state *uts)
{
struct udevice *dev_reset;
struct udevice *dev_test;
ut_assertok(uclass_get_device_by_name(UCLASS_RESET, "reset-ctl",
&dev_reset));
ut_asserteq(0, sandbox_reset_query(dev_reset, TEST_RESET_ID));
ut_assertok(uclass_get_device_by_name(UCLASS_MISC, "reset-ctl-test",
&dev_test));
ut_assertok(sandbox_reset_test_get_devm(dev_test));
ut_assertok(sandbox_reset_test_assert(dev_test));
ut_asserteq(1, sandbox_reset_query(dev_reset, TEST_RESET_ID));
ut_assertok(sandbox_reset_test_deassert(dev_test));
ut_asserteq(0, sandbox_reset_query(dev_reset, TEST_RESET_ID));
ut_asserteq(1, sandbox_reset_is_requested(dev_reset, TEST_RESET_ID));
ut_assertok(device_remove(dev_test, DM_REMOVE_NORMAL));
ut_asserteq(0, sandbox_reset_is_requested(dev_reset, TEST_RESET_ID));
return 0;
}
DM_TEST(dm_test_reset_devm, UTF_SCAN_FDT);
static int dm_test_reset_reset(struct unit_test_state *uts)
{
struct udevice *dev_reset;
struct udevice *dev_test;
ut_assertok(uclass_get_device_by_name(UCLASS_RESET, "reset-ctl",
&dev_reset));
ut_asserteq(0, sandbox_reset_query(dev_reset, TEST_RESET_ID));
ut_assertok(uclass_get_device_by_name(UCLASS_MISC, "reset-ctl-test",
&dev_test));
ut_assertok(sandbox_reset_test_get(dev_test));
/* Verify reset_count starts at 0 */
ut_asserteq(0, sandbox_reset_get_count(dev_reset, TEST_RESET_ID));
ut_assertok(sandbox_reset_test_assert(dev_test));
ut_asserteq(1, sandbox_reset_query(dev_reset, TEST_RESET_ID));
ut_assertok(sandbox_reset_test_reset(dev_test));
/* Verify reset was pulsed (count incremented) */
ut_asserteq(1, sandbox_reset_get_count(dev_reset, TEST_RESET_ID));
ut_asserteq(0, sandbox_reset_query(dev_reset, TEST_RESET_ID));
ut_assertok(sandbox_reset_test_free(dev_test));
return 0;
}
DM_TEST(dm_test_reset_reset, UTF_SCAN_FDT);
/*
* reset_reset() fallback path: controller has no rst_reset op, so the
* core does assert -> udelay -> deassert. rst_reset-only accounting
* (reset_count) stays zero. Leave the line asserted before reset_reset()
* so we verify the fallback actually pulses it back to deasserted.
*/
static int dm_test_reset_reset_fallback_path(struct unit_test_state *uts)
{
struct udevice *dev_reset_fb;
struct udevice *dev_test;
struct reset_ctl ctl;
ut_assertok(uclass_get_device_by_name(UCLASS_RESET, "reset-ctl-fallback",
&dev_reset_fb));
ut_asserteq(0, sandbox_reset_query(dev_reset_fb, FALLBACK_RESET_ID));
ut_asserteq(0, sandbox_reset_get_count(dev_reset_fb, FALLBACK_RESET_ID));
ut_assertok(uclass_get_device_by_name(UCLASS_MISC, "reset-ctl-test",
&dev_test));
ut_assertok(reset_get_by_name(dev_test, "fallback", &ctl));
ut_asserteq_ptr(ctl.dev, dev_reset_fb);
ut_asserteq(FALLBACK_RESET_ID, ctl.id);
ut_assertok(reset_assert(&ctl));
ut_asserteq(1, sandbox_reset_query(dev_reset_fb, FALLBACK_RESET_ID));
ut_asserteq(0, sandbox_reset_get_count(dev_reset_fb, FALLBACK_RESET_ID));
ut_assertok(reset_reset(&ctl, 1));
ut_asserteq(0, sandbox_reset_get_count(dev_reset_fb, FALLBACK_RESET_ID));
ut_asserteq(0, sandbox_reset_query(dev_reset_fb, FALLBACK_RESET_ID));
ut_assertok(reset_free(&ctl));
return 0;
}
DM_TEST(dm_test_reset_reset_fallback_path, UTF_SCAN_FDT);
static int dm_test_reset_reset_bulk(struct unit_test_state *uts)
{
struct udevice *dev_reset;
struct udevice *dev_test;
ut_assertok(uclass_get_device_by_name(UCLASS_RESET, "reset-ctl",
&dev_reset));
ut_asserteq(0, sandbox_reset_query(dev_reset, TEST_RESET_ID));
ut_asserteq(0, sandbox_reset_query(dev_reset, OTHER_RESET_ID));
ut_assertok(uclass_get_device_by_name(UCLASS_MISC, "reset-ctl-test",
&dev_test));
ut_assertok(sandbox_reset_test_get_bulk(dev_test));
/* Verify reset_count starts at 0 */
ut_asserteq(0, sandbox_reset_get_count(dev_reset, TEST_RESET_ID));
ut_asserteq(0, sandbox_reset_get_count(dev_reset, OTHER_RESET_ID));
ut_assertok(sandbox_reset_test_assert_bulk(dev_test));
ut_asserteq(1, sandbox_reset_query(dev_reset, TEST_RESET_ID));
ut_asserteq(1, sandbox_reset_query(dev_reset, OTHER_RESET_ID));
ut_assertok(sandbox_reset_test_reset_bulk(dev_test));
/* Verify resets were pulsed (counts incremented) */
ut_asserteq(1, sandbox_reset_get_count(dev_reset, TEST_RESET_ID));
ut_asserteq(1, sandbox_reset_get_count(dev_reset, OTHER_RESET_ID));
ut_asserteq(0, sandbox_reset_query(dev_reset, TEST_RESET_ID));
ut_asserteq(0, sandbox_reset_query(dev_reset, OTHER_RESET_ID));
ut_assertok(sandbox_reset_test_release_bulk(dev_test));
return 0;
}
DM_TEST(dm_test_reset_reset_bulk, UTF_SCAN_FDT);
static int dm_test_reset_bulk(struct unit_test_state *uts)
{
struct udevice *dev_reset;
struct udevice *dev_test;
ut_assertok(uclass_get_device_by_name(UCLASS_RESET, "reset-ctl",
&dev_reset));
ut_asserteq(0, sandbox_reset_query(dev_reset, TEST_RESET_ID));
ut_asserteq(0, sandbox_reset_query(dev_reset, OTHER_RESET_ID));
ut_assertok(uclass_get_device_by_name(UCLASS_MISC, "reset-ctl-test",
&dev_test));
ut_assertok(sandbox_reset_test_get_bulk(dev_test));
ut_assertok(sandbox_reset_test_assert_bulk(dev_test));
ut_asserteq(1, sandbox_reset_query(dev_reset, TEST_RESET_ID));
ut_asserteq(1, sandbox_reset_query(dev_reset, OTHER_RESET_ID));
ut_assertok(sandbox_reset_test_deassert_bulk(dev_test));
ut_asserteq(0, sandbox_reset_query(dev_reset, TEST_RESET_ID));
ut_asserteq(0, sandbox_reset_query(dev_reset, OTHER_RESET_ID));
ut_assertok(sandbox_reset_test_release_bulk(dev_test));
ut_asserteq(1, sandbox_reset_query(dev_reset, TEST_RESET_ID));
ut_asserteq(1, sandbox_reset_query(dev_reset, OTHER_RESET_ID));
return 0;
}
DM_TEST(dm_test_reset_bulk, UTF_SCAN_FDT);
static int dm_test_reset_bulk_devm(struct unit_test_state *uts)
{
struct udevice *dev_reset;
struct udevice *dev_test;
ut_assertok(uclass_get_device_by_name(UCLASS_RESET, "reset-ctl",
&dev_reset));
ut_asserteq(0, sandbox_reset_query(dev_reset, TEST_RESET_ID));
ut_asserteq(0, sandbox_reset_query(dev_reset, OTHER_RESET_ID));
ut_assertok(uclass_get_device_by_name(UCLASS_MISC, "reset-ctl-test",
&dev_test));
ut_assertok(sandbox_reset_test_get_bulk_devm(dev_test));
ut_assertok(sandbox_reset_test_assert_bulk(dev_test));
ut_asserteq(1, sandbox_reset_query(dev_reset, TEST_RESET_ID));
ut_asserteq(1, sandbox_reset_query(dev_reset, OTHER_RESET_ID));
ut_assertok(sandbox_reset_test_deassert_bulk(dev_test));
ut_asserteq(0, sandbox_reset_query(dev_reset, TEST_RESET_ID));
ut_asserteq(0, sandbox_reset_query(dev_reset, OTHER_RESET_ID));
ut_asserteq(1, sandbox_reset_is_requested(dev_reset, OTHER_RESET_ID));
ut_asserteq(1, sandbox_reset_is_requested(dev_reset, TEST_RESET_ID));
ut_assertok(device_remove(dev_test, DM_REMOVE_NORMAL));
ut_asserteq(0, sandbox_reset_is_requested(dev_reset, TEST_RESET_ID));
ut_asserteq(0, sandbox_reset_is_requested(dev_reset, OTHER_RESET_ID));
return 0;
}
DM_TEST(dm_test_reset_bulk_devm, UTF_SCAN_FDT);
Reference in New Issue View Git Blame Copy Permalink