From 055563bd921a07cfdfcc4e443edf8f70793e71f4 Mon Sep 17 00:00:00 2001 From: vhaudiquet Date: Sun, 30 Aug 2026 20:46:36 +0200 Subject: [PATCH] krane: restore CONFIG_USB dropped by the R35 defconfig edit; rotate 270 The R35 rotation edit used PUT 77.=77 against a stale line number and overwrote CONFIG_USB=y with a duplicate VIDEO block, leaving the USB menuconfig unset: no USB controller, no usb command, no keyboard. Restore CONFIG_USB=y (deduplicate VIDEO) and verify the full USB set in .config after the defconfig re-run. Also flip the console rotation from 1 (90 degrees clockwise) to 3 (270 degrees clockwise): rot=1 read upside down on the device with the keyboard attached. --- configs/mt8183_kukui_krane_defconfig | 3 +-- drivers/video/mt8183_scanout.c | 12 +++++++----- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/configs/mt8183_kukui_krane_defconfig b/configs/mt8183_kukui_krane_defconfig index c2a6ae7c8db..9ed4de54bd0 100644 --- a/configs/mt8183_kukui_krane_defconfig +++ b/configs/mt8183_kukui_krane_defconfig @@ -74,9 +74,8 @@ CONFIG_VIDEO_MT8183_SCANOUT=y CONFIG_MMC_MTK=y CONFIG_PHY=y CONFIG_PHY_MTK_TPHY=y -CONFIG_VIDEO=y -CONFIG_VIDEO_MT8183_SCANOUT=y CONFIG_CONSOLE_ROTATION=y +CONFIG_USB=y CONFIG_DM_USB=y CONFIG_USB_XHCI_HCD=y CONFIG_USB_XHCI_MTK=y diff --git a/drivers/video/mt8183_scanout.c b/drivers/video/mt8183_scanout.c index 9d6b3c904a9..5f0bb44ce7d 100644 --- a/drivers/video/mt8183_scanout.c +++ b/drivers/video/mt8183_scanout.c @@ -349,12 +349,14 @@ static int mt8183_scanout_probe(struct udevice *dev) * The BOE TV101WUM-NL6 panel is mounted rotated 270 degrees in * the krane chassis (see the panel node's "rotation" property in * the upstream DT). The keyboard-covered landscape orientation - * therefore needs the console rotated by 90 degrees clockwise - * relative to the native scanout; the uclass then binds the - * rotated vidconsole1 text driver, which swaps the console - * geometry (240x75 columns/rows on this panel). + * therefore needs the console rotated; the uclass then binds the + * rotated vidconsole3 text driver, which writes glyphs rotated + * by 270 degrees clockwise into the native 1200x1920 portrait + * scanout and swaps the console geometry (240x75 columns/rows + * on this panel). rot=1 (90 degrees) was tried first and read + * upside down on the device (R35). */ - uc_priv->rot = 1; + uc_priv->rot = 3; printf("Video: MT8183 scanout %dx%d@32bpp at %llx\n", uc_priv->xsize, uc_priv->ysize, (unsigned long long)plat->base);