From 74c3744d39424cbdf32a08a847ec57129db60efa Mon Sep 17 00:00:00 2001 From: Valentin Haudiquet Date: Wed, 28 Oct 2026 13:20:02 +0100 Subject: [PATCH] fix(cli): remove the --arch flag KVM runs only the host architecture, so the flag could not mean what it suggested: a mismatched value downloaded a foreign rootfs that extracted cleanly and died at boot with a cryptic guest-side exec error. The flag's real job, picking the image variant to fetch, is the library's; RunOptions.arch keeps that role and an empty value still resolves to the host architecture. --- crates/ecrou-cli/src/cli.rs | 3 --- crates/ecrou-cli/src/main.rs | 3 --- 2 files changed, 6 deletions(-) diff --git a/crates/ecrou-cli/src/cli.rs b/crates/ecrou-cli/src/cli.rs index 21c2c21..685feb9 100644 --- a/crates/ecrou-cli/src/cli.rs +++ b/crates/ecrou-cli/src/cli.rs @@ -46,9 +46,6 @@ pub struct RunArgs { /// Guest environment KEY=VALUE (repeatable) #[arg(short = 'e', long = "env")] pub env: Vec, - /// Target architecture; the host architecture when omitted - #[arg(short = 'a', long)] - pub arch: Option, /// Suppress console noise #[arg(long)] pub quiet: bool, diff --git a/crates/ecrou-cli/src/main.rs b/crates/ecrou-cli/src/main.rs index cda7070..bf75252 100644 --- a/crates/ecrou-cli/src/main.rs +++ b/crates/ecrou-cli/src/main.rs @@ -38,9 +38,6 @@ fn cmd_run(args: &RunArgs, cli_verbose: bool) -> std::process::ExitCode { no_cache: args.no_cache, ..RunOptions::default() }; - if let Some(arch) = &args.arch { - options.arch = arch.clone(); - } for spec in &args.env { match parse_env(spec) { Ok((k, v)) => options.env.push((k, v)),