refactor(build): use dmgbuild to create dmgs (#1664)

* refactor(appdmg): make dmgs with dmgbuild

* fix(appdmg.sh): typo

* refactor(appdmg.sh): don't generate config on the fly

* fix(dmgbuild): icon file

* fix(gitignore): dmgbuild settings

* chore(resources): update readme with new files

* chore(resources/macos): add missing newline

scripts/README.md

@@ -10,7 +10,7 @@ Various scripts and configurations used to configure, build, and package Lite XL
 
 ### Package
 
-- **appdmg.sh**:    Create a macOS DMG image using [AppDMG][1].
+- **appdmg.sh**:    Create a macOS DMG image using [dmgbuild][1].
 - **appimage.sh**:  [AppImage][2] builder.
 - **innosetup.sh**: Creates a 32/64 bit [InnoSetup][3] installer package.
 - **package.sh**:   Creates all binary / DMG image / installer / source packages.
@@ -25,6 +25,6 @@ Various scripts and configurations used to configure, build, and package Lite XL
 - **generate_header.sh**: Generates a header file for native plugin API
 - **keymap-generator**: Generates a JSON file containing the keymap
 
-[1]: https://github.com/LinusU/node-appdmg
+[1]: https://github.com/dmgbuild/dmgbuild
 [2]: https://docs.appimage.org/
 [3]: https://jrsoftware.org/isinfo.php

scripts/appdmg.sh

@@ -6,25 +6,4 @@ if [ ! -e "src/api/api.h" ]; then
   exit 1
 fi
 
-cat > lite-xl-dmg.json << EOF
-{
-  "title": "Lite XL",
-  "icon": "$(pwd)/resources/icons/icon.icns",
-  "background": "$(pwd)/resources/macos/appdmg.png",
-  "window": {
-    "position": {
-      "x": 360,
-      "y": 360
-    },
-    "size": {
-      "width": 480,
-      "height": 360
-    }
-  },
-  "contents": [
-    { "x": 144, "y": 248, "type": "file", "path": "$(pwd)/Lite XL.app" },
-    { "x": 336, "y": 248, "type": "link", "path": "/Applications" }
-  ]
-}
-EOF
-~/node_modules/appdmg/bin/appdmg.js lite-xl-dmg.json "$(pwd)/$1.dmg"
+dmgbuild -s resources/macos/lite-xl-dmg.py "Lite XL" "$1.dmg"

scripts/install-dependencies.sh

@@ -57,9 +57,7 @@ main() {
     else
       brew install bash ninja sdl2
     fi
-    pip3 install meson
-    cd ~; npm install appdmg; cd -
-    ~/node_modules/appdmg/bin/appdmg.js --version
+    pip3 install meson dmgbuild
   elif [[ "$OSTYPE" == "msys" ]]; then
     if [[ $lhelper == true ]]; then
       pacman --noconfirm -S \

scripts/package.sh

@@ -25,7 +25,7 @@ show_help() {
   echo "-A --appimage                 Create an AppImage (Linux only)."
   echo "-B --binary                   Create a normal / portable package or macOS bundle,"
   echo "                              depending on how the build was configured. (Default.)"
-  echo "-D --dmg                      Create a DMG disk image with AppDMG (macOS only)."
+  echo "-D --dmg                      Create a DMG disk image with dmgbuild (macOS only)."
   echo "-I --innosetup                Create a InnoSetup package (Windows only)."
   echo "-r --release                  Strip debugging symbols."
   echo "-S --source                   Create a source code package,"