From afb9f106f95d9c57a71a11691b6a028793046091 Mon Sep 17 00:00:00 2001
From: vhaudiquet <vhaudiquet343@hotmail.fr>
Date: Thu, 28 Nov 2024 18:36:57 +0100
Subject: [PATCH] More typescript

---
 frontend/components/ChampionSelector.vue | 13 +----------
 frontend/components/ChampionTitle.vue    | 29 +++++++-----------------
 frontend/types/cdragon.ts                | 27 ++++++++++++++++++++++
 frontend/types/items.ts                  |  6 -----
 4 files changed, 36 insertions(+), 39 deletions(-)
 create mode 100644 frontend/types/cdragon.ts

diff --git a/frontend/components/ChampionSelector.vue b/frontend/components/ChampionSelector.vue
index 59d04f8..100bd0b 100644
--- a/frontend/components/ChampionSelector.vue
+++ b/frontend/components/ChampionSelector.vue
@@ -1,13 +1,5 @@
 <script setup lang="ts">
-type ChampionResponse = {
-    data: Ref<Array<Champion>>
-}
-type Champion = {
-    name: string
-    alias: string
-    squarePortraitPath: string
-}
-const {data: championsData} : ChampionResponse = await useFetch(CDRAGON_BASE + "plugins/rcp-be-lol-game-data/global/default/v1/champion-summary.json")
+const {data: championsData} : ChampionsResponse = await useFetch(CDRAGON_BASE + "plugins/rcp-be-lol-game-data/global/default/v1/champion-summary.json")
 const champions = championsData.value.slice(1).sort((a, b) => {
     if(a.name < b.name) return -1;
     if(a.name > b.name) return 1;
@@ -46,9 +38,6 @@ function filterToLane(filter: number) {
 
 function onLaneFilterChange(newValue: number) {
     if(newValue != -1) {
-        
-        
-        
         filteredChampions.value = champions.filter((champion) => {
             const lanes : Array<any> = lanesMap.get(champion.alias.toLowerCase())
             if(lanes == undefined) return false;
diff --git a/frontend/components/ChampionTitle.vue b/frontend/components/ChampionTitle.vue
index 451b441..74ed3c1 100644
--- a/frontend/components/ChampionTitle.vue
+++ b/frontend/components/ChampionTitle.vue
@@ -1,22 +1,10 @@
-<script setup>
-const props = defineProps({
-  championId: {
-    type: String,
-    required: true
-  },
-  winrate: {
-    type: Number,
-    required: true
-  },
-  pickrate: {
-    type: Number,
-    required: true
-  },
-  gameCount: {
-    type: Number,
-    required: true
-  }
-})
+<script setup lang="ts">
+const props = defineProps<{
+  championId: string,
+  winrate: number,
+  pickrate: number,
+  gameCount: number
+}>()
 
 const championId = Number(props.championId)
 
@@ -24,10 +12,9 @@ const winrate = (props.winrate * 100).toFixed(2)
 const pickrate = (props.pickrate * 100).toFixed(2)
 const gameCount = props.gameCount
 
-const { data: championData } = await useFetch(CDRAGON_BASE + "plugins/rcp-be-lol-game-data/global/default/v1/champions/" + championId + ".json")
+const { data: championData } : ChampionResponse = await useFetch(CDRAGON_BASE + "plugins/rcp-be-lol-game-data/global/default/v1/champions/" + championId + ".json")
 const championName = championData.value.name
 const championDescription = championData.value.title
-
 </script>
 
 <template>
diff --git a/frontend/types/cdragon.ts b/frontend/types/cdragon.ts
new file mode 100644
index 0000000..b4105fa
--- /dev/null
+++ b/frontend/types/cdragon.ts
@@ -0,0 +1,27 @@
+declare global {
+    type ChampionsResponse = {
+        data: Ref<Array<Champion>>
+    }
+    type ChampionResponse = {
+        data: Ref<ChampionFull>
+    }
+    type Champion = {
+        name: string
+        alias: string
+        squarePortraitPath: string
+    }
+    type ChampionFull = {
+        name: string
+        alias: string
+        squarePortraitPath: string
+        title: string
+    }
+    type ItemResponse = {
+        data: Ref<Array<Item>>
+    }
+    type Item = {
+        id: number
+    }
+}
+
+export {}
\ No newline at end of file
diff --git a/frontend/types/items.ts b/frontend/types/items.ts
index b15f2b7..c1f683a 100644
--- a/frontend/types/items.ts
+++ b/frontend/types/items.ts
@@ -11,12 +11,6 @@ declare global {
         boots: Array<{count: number, data: number}>
         lateGame: Array<{count: number, data: number}>
     }
-    type Item = {
-        id: number
-    }
-    type ItemResponse = {
-        data: Ref<Array<Item>>
-    }
 }
 
 export {};
\ No newline at end of file