From 56e4b89aeaec4c195d2c74cb9aac7a4d94917f1f Mon Sep 17 00:00:00 2001
From: vhaudiquet <vhaudiquet343@hotmail.fr>
Date: Fri, 6 Dec 2024 17:24:33 +0100
Subject: [PATCH] Refactor

---
 frontend/components/tierlist/Chart.vue |  4 ++--
 frontend/pages/tierlist/[lane].vue     | 19 ++++++++-----------
 2 files changed, 10 insertions(+), 13 deletions(-)

diff --git a/frontend/components/tierlist/Chart.vue b/frontend/components/tierlist/Chart.vue
index 200254b..c84e9f6 100644
--- a/frontend/components/tierlist/Chart.vue
+++ b/frontend/components/tierlist/Chart.vue
@@ -6,7 +6,7 @@ import { Bar } from 'vue-chartjs'
 ChartJS.register(Title, Tooltip, Legend, BarElement, CategoryScale, LinearScale)
 
 const props = defineProps<{
-    data: Array<Array<{champion: Champion, lane: LaneData}>>
+    data: Array<{title:string, data: Array<{lane: LaneData, champion: Champion}>}>
 }>()
 
 const labels: Array<string> = []
@@ -19,7 +19,7 @@ const datasets = []
 let count = 0
 let colorIndex = 0
 for(let tier of props.data) {
-    for(let {champion: champion, lane: lane} of tier) {
+    for(let {champion: champion, lane: lane} of tier.data) {
         if(count > 35) break;
 
         labels.push(champion.name)
diff --git a/frontend/pages/tierlist/[lane].vue b/frontend/pages/tierlist/[lane].vue
index e98833a..564a7e7 100644
--- a/frontend/pages/tierlist/[lane].vue
+++ b/frontend/pages/tierlist/[lane].vue
@@ -47,11 +47,12 @@ function tierFromScaledPickrate(min: number, max: number) {
         })
 }
 
-const s_tier = tierFromScaledPickrate(0.9, 1)
-const a_tier = tierFromScaledPickrate(0.7, 0.9)
-const b_tier = tierFromScaledPickrate(0.5, 0.7)
-const c_tier = tierFromScaledPickrate(0.3, 0.5)
-const d_tier = tierFromScaledPickrate(0.1, 0.3)
+const tiers: Array<{title:string, data: Array<{lane: LaneData, champion: Champion}>}> = []
+tiers.push({title: "S", data: tierFromScaledPickrate(0.9, 1)})
+tiers.push({title: "A", data: tierFromScaledPickrate(0.7, 0.9)})
+tiers.push({title: "B", data: tierFromScaledPickrate(0.5, 0.7)})
+tiers.push({title: "C", data: tierFromScaledPickrate(0.3, 0.5)})
+tiers.push({title: "D", data: tierFromScaledPickrate(0.1, 0.3)})
 </script>
 
 <template>
@@ -70,13 +71,9 @@ const d_tier = tierFromScaledPickrate(0.1, 0.3)
             <h1 style="margin-left: 10px; font-size: 45px; font-weight: 300;">{{ POSITIONS_STR[lanePositionToIndex(lane)] }}</h1>
         </div>
 
-        <TierlistTier title="S" :tier="s_tier" />
-        <TierlistTier title="A" :tier="a_tier" />
-        <TierlistTier title="B" :tier="b_tier" />
-        <TierlistTier title="C" :tier="c_tier" />
-        <TierlistTier title="D" :tier="d_tier" />
+        <TierlistTier v-for="tier in tiers" :title="tier.title" :tier="tier.data" />
 
-        <TierlistChart style="margin-left: 100px; margin-right: 100px; margin-bottom: 100px; margin-top: 40px" :data="[s_tier, a_tier, b_tier, c_tier, d_tier]" />
+        <TierlistChart style="margin-left: 100px; margin-right: 100px; margin-bottom: 100px; margin-top: 40px" :data="tiers" />
 
         </div>
     </div>